Skip to content

Use relURL for relative links #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2025
Merged

Use relURL for relative links #1175

merged 3 commits into from
Feb 20, 2025

Conversation

@paoloredis
Copy link
Collaborator

@paoloredis paoloredis commented Feb 18, 2025 •
edited
Loading

@paoloredis
Copy link
Collaborator Author

paoloredis commented Feb 18, 2025

This fixes the double slash issue

@mich-elle-luna
Copy link
Collaborator

mich-elle-luna commented Feb 18, 2025

Thank you, I still see a dbl slash in the command links on pages like this one https://redis.io/docs/staging/DOC-4864/commands/bf.loadchunk/

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Staging links:
https://redis.io/docs/staging/DOC-4864/commands/acl-setuser/
https://redis.io/docs/staging/DOC-4864/commands/bf.add/
https://redis.io/docs/staging/DOC-4864/commands/bf.exists/
https://redis.io/docs/staging/DOC-4864/commands/bf.insert/
https://redis.io/docs/staging/DOC-4864/commands/bf.loadchunk/
https://redis.io/docs/staging/DOC-4864/commands/bf.madd/
https://redis.io/docs/staging/DOC-4864/commands/bf.mexists/
https://redis.io/docs/staging/DOC-4864/commands/bf.scandump/
https://redis.io/docs/staging/DOC-4864/commands/cf.add/
https://redis.io/docs/staging/DOC-4864/commands/cf.addnx/
https://redis.io/docs/staging/DOC-4864/commands/cf.count/
https://redis.io/docs/staging/DOC-4864/commands/cf.exists/
https://redis.io/docs/staging/DOC-4864/commands/cf.insert/
https://redis.io/docs/staging/DOC-4864/commands/cf.insertnx/
https://redis.io/docs/staging/DOC-4864/commands/cf.loadchunk/
https://redis.io/docs/staging/DOC-4864/commands/cf.mexists/
https://redis.io/docs/staging/DOC-4864/commands/cf.scandump/
https://redis.io/docs/staging/DOC-4864/commands/command-getkeys/
https://redis.io/docs/staging/DOC-4864/commands/command-getkeysandflags/
https://redis.io/docs/staging/DOC-4864/commands/command-list/
https://redis.io/docs/staging/DOC-4864/commands/eval/
https://redis.io/docs/staging/DOC-4864/commands/eval_ro/
https://redis.io/docs/staging/DOC-4864/commands/evalsha_ro/
https://redis.io/docs/staging/DOC-4864/commands/fcall_ro/
https://redis.io/docs/staging/DOC-4864/commands/ft.aggregate/
https://redis.io/docs/staging/DOC-4864/commands/ft.aliasadd/
https://redis.io/docs/staging/DOC-4864/commands/ft.aliasdel/
https://redis.io/docs/staging/DOC-4864/commands/ft.aliasupdate/
https://redis.io/docs/staging/DOC-4864/commands/ft.alter/
https://redis.io/docs/staging/DOC-4864/commands/ft.config-get/

@paoloredis
Copy link
Collaborator Author

paoloredis commented Feb 19, 2025

Thank you, I still see a dbl slash in the command links on pages like this one https://redis.io/docs/staging/DOC-4864/commands/bf.loadchunk/

Thanks, that's been fixed now. The issue was a result of a breaking change they made (gohugoio/hugo#11669) which affected how baseURL works.

@mich-elle-luna
Copy link
Collaborator

mich-elle-luna commented Feb 19, 2025

For some reason, these image refs are broken https://redis.io/docs/staging/DOC-4864/operate/rc/api/get-started/use-rest-api/

@paoloredis
Copy link
Collaborator Author

paoloredis commented Feb 19, 2025

Thanks, I had just noticed that. That's been fixed now.

mich-elle-luna
mich-elle-luna approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@paoloredis paoloredis merged commit 1513774 into main Feb 20, 2025
5 checks passed
@paoloredis paoloredis deleted the DOC-4864 branch February 20, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mich-elle-luna mich-elle-luna mich-elle-luna approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paoloredis @mich-elle-luna